Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics-generator: use exemplars from native histograms #4482

Open
yvrhdn opened this issue Dec 20, 2024 · 1 comment
Open

Metrics-generator: use exemplars from native histograms #4482

yvrhdn opened this issue Dec 20, 2024 · 1 comment
Labels
stale Used for stale issues / PRs

Comments

@yvrhdn
Copy link
Member

yvrhdn commented Dec 20, 2024

Is your feature request related to a problem? Please describe.

While updating a bunch of dependencies in #4466, prometheus/client_golang also got updated. In this update they refactored how native histogram generate exemplars which also changes our usage of native histograms in the metrics-generator. I'm not sure if only our tests need to be updated or also the implementation.

Prometheus PR adding native histogram exemplars: prometheus/client_golang#1471

As a workaround I have disabled NativeHistogramMaxExemplars for now.

Describe the solution you'd like

We should make use of these exemplars but ensure they don't conflict or overlap with classic histograms.

Describe alternatives you've considered

Additional context

Metrics-generator can generate histogram in three modes: classic, native histograms or both. We should make exemplars well work in all 3 modes.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used for stale issues / PRs
Projects
None yet
Development

No branches or pull requests

1 participant