-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output when execution fails #12
Comments
Hi @filhodanuvem! Thank you for noticing that...it's not much help when the command silently fails. |
+1 to this feature! |
What would be the best return for the exec.command in this case? Log the error and return an empty string? Log the error and return the exit status as a string? Or return the same string that is being printed in the log.fatal (but without interrupting the main execution? |
Out of curiosity, I went looking for the forks of this project and it seems that changing this is a popular motivator forforking. Some replace this It would be nice to have one of the patches landed on the main project. Is there any reason not to do it? What is missing? The pull requests? |
In my opinion it is just about creating the pull request, time has passed and I didn't do it. Go for it @fczuardi if that unblocks you in any way. Lines 49 to 58 in 997ee1b
|
So, this was bothering me as well, so I created PR #20 that allows to specify an option I also took the oportunity to add support for an |
I think it would be helpful to have a way to see/get the output of failure executions, from what I see we don't have it because the
log.fatal
here exits the run.What do you think?
The text was updated successfully, but these errors were encountered: