Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SN auth sample distribution is far more variable than necessary #268

Open
jagerman opened this issue Mar 22, 2019 · 1 comment
Open

SN auth sample distribution is far more variable than necessary #268

jagerman opened this issue Mar 22, 2019 · 1 comment

Comments

@jagerman
Copy link
Contributor

The current SN auth sampling exhibits significant correlation from one block to the next because it selects 16 nodes from the previous block's sample list.

The non-independent sampling makes the selection pattern considerably more erratic over time, with a noticeable increase in the variance of the number of times a SN is selected. This doesn't bias the results in any particular way, but the higher variance means it will take considerably longer for the distribution to approach a fair distribution.

The design document on selection simply states that it will do this, but provides no justification at all for its use. This is puzzling to me: normally adding complexity is something that should be done for a specific reason, but no reason has been presented and the reasoning is not obvious, at least to me.

Perhaps the dev team can elaborate on why deliberately correlating the auth sample sublist across sequential block samples (and thus considerably driving up the selection frequency variance) is a desirable characteristic?

@jagerman jagerman changed the title SN auth sample distribution is bad SN auth sample distribution is far more variable than necessary Mar 22, 2019
@Fez29
Copy link
Contributor

Fez29 commented Apr 13, 2019

I agree with the above and think justification should be presented for such additional complexities introduced into the code. And why its a desirable "feature"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants