Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce broadcasting is unreliable #269

Open
jagerman opened this issue Mar 22, 2019 · 2 comments
Open

Announce broadcasting is unreliable #269

jagerman opened this issue Mar 22, 2019 · 2 comments

Comments

@jagerman
Copy link
Contributor

As expected, throwing a random component into whether nodes forward announces is causing massive inconsistencies across the network. Different nodes have considerably different views of what nodes are online. For example, this is just two:

Uptime counts:
Node 1: 123 nodes <= 2m; 233 <= 10m; 95 <= 30m; 41 <= 60m; 48 offline (>1h).
Node 2: 81 nodes <= 2m; 146 <= 10m; 142 <= 30m; 79 <= 60m; 83 offline (>1h).

The entire rationale for 1-minute (originally; now 90-second) announces was that it is important to know when a node goes offline as soon as possible.

That is not even remotely close to being accomplished here; even a 1-hour threshold is resulting in a large number of false positives: node 2 above hasn't heard from 17% of the network in more than an hour.

A short announce frequency with flakey-by-design announce propagation through the network is, to put it mildly, a bad design.

@SomethingGettingWrong

This comment was marked as abuse.

@rainmanp7
Copy link

He's talking about the various servers not communicating all the same.
In referring to the announcement time given off and response from other nodes.
But not realizing people setup there nodes differently.
Some people are behind different hardware and specs.
I'm still wondering if he is pissed at the random reward given out..
That was my own personal concept a long time ago ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants