Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grails-plugin-async is resolving as async-###.jar #154

Open
codeconsole opened this issue Oct 11, 2024 · 7 comments
Open

grails-plugin-async is resolving as async-###.jar #154

codeconsole opened this issue Oct 11, 2024 · 7 comments

Comments

@codeconsole
Copy link
Contributor

It should resolve as grails-plugin-async-###.jar
@codeconsole codeconsole moved this to Todo in Grails 6.2.2 Oct 11, 2024
@jamesfredley
Copy link
Contributor

It appears that nearly all of https://mvnrepository.com/artifact/org.grails.plugins and https://mvnrepository.com/artifact/org.grails.profiles are this way.

Ex:
https://repo1.maven.org/maven2/org/grails/plugins/scaffolding/5.1.2/
https://repo.grails.org/ui/native/core/org/grails/plugins/geb/4.0.0/
https://repo1.maven.org/maven2/org/grails/profiles/web/7.0.0/

@codeconsole
Copy link
Contributor Author

codeconsole commented Oct 11, 2024 •
edited
Loading

@jamesfredley The problem is async is in particularly more confusing:

    57877  10-10-2024 05:31   BOOT-INF/lib/async-5.0.2.jar
    66394  10-10-2024 05:33   BOOT-INF/lib/grails-async-5.0.2.jar

However, behavior should be consistent.

   319912  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-databinding-6.2.1.jar
    17658  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-services-6.2.1.jar
    37054  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-interceptors-6.2.1.jar
   222905  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-rest-6.2.1.jar
    22224  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-url-mappings-6.2.1.jar
   109746  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-controllers-6.2.1.jar
    25070  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-datasource-6.2.1.jar
    15478  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-i18n-6.2.1.jar
    27675  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-codecs-6.2.1.jar
    72745  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-mimetypes-6.2.1.jar
    24400  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-domain-class-6.2.1.jar
    22882  10-11-2024 20:07   BOOT-INF/lib/grails-plugin-validation-6.2.1.jar

@matrei
Copy link
Collaborator

matrei commented Oct 11, 2024

The naming pattern seems to be:
Plugins in org.grails.plugins -> name
Plugins in org.grails -> grails-plugin-name

@matrei
Copy link
Collaborator

matrei commented Oct 11, 2024

grails-async-5.0.2.jar is the grails-async-core module.
That could probably be named better.

@codeconsole
Copy link
Contributor Author

codeconsole commented Oct 11, 2024 •
edited
Loading

The naming pattern seems to be: Plugins in org.grails.plugins -> name Plugins in org.grails -> grails-plugin-name

@matrei is that a good naming pattern? should jar name resolution be intuitive?

having a module async seems prone to potential name clashes.

All micronaut dependencies are prefixed micronaut:

grep \\.jar|grep spring

   81081  10-10-2024 05:32    BOOT-INF/lib/micronaut-spring-context-4.5.1.jar
   102017  10-10-2024 05:32   BOOT-INF/lib/micronaut-cache-core-3.5.0.jar
    54837  10-10-2024 05:32   BOOT-INF/lib/micronaut-spring-4.5.1.jar
   202553  10-10-2024 05:32   BOOT-INF/lib/micronaut-runtime-3.10.4.jar
   152743  10-10-2024 05:32   BOOT-INF/lib/micronaut-jackson-databind-3.10.4.jar
    39648  10-10-2024 05:32   BOOT-INF/lib/micronaut-jackson-core-3.10.4.jar
    53421  10-10-2024 05:32   BOOT-INF/lib/micronaut-json-core-3.10.4.jar
   234133  10-10-2024 05:32   BOOT-INF/lib/micronaut-context-3.10.4.jar
    92987  10-10-2024 05:32   BOOT-INF/lib/micronaut-aop-3.10.4.jar
   389473  10-10-2024 05:32   BOOT-INF/lib/micronaut-http-3.10.4.jar
   998102  10-10-2024 05:31   BOOT-INF/lib/micronaut-inject-3.10.4.jar
    45298  10-10-2024 05:33   BOOT-INF/lib/micronaut-core-reactive-3.10.4.jar
  1645283  10-10-2024 05:31   BOOT-INF/lib/micronaut-core-3.10.4.jar

All spring dependencies are prefixed spring:

grep \\.jar|grep spring

    40747  12-24-2023 19:58   BOOT-INF/lib/spring-security-stateless-v1.2.3.jar
   583548  10-11-2024 20:07   BOOT-INF/lib/spring-security-core-6.1.1.jar
    81081  10-10-2024 05:32   BOOT-INF/lib/micronaut-spring-context-4.5.1.jar
    54837  10-10-2024 05:32   BOOT-INF/lib/micronaut-spring-4.5.1.jar
   576434  10-10-2024 05:32   BOOT-INF/lib/spring-boot-actuator-autoconfigure-2.7.18.jar
  1691093  10-10-2024 05:32   BOOT-INF/lib/spring-boot-autoconfigure-2.7.18.jar
   405764  10-11-2024 20:07   BOOT-INF/lib/spring-security-oauth2-client-5.8.14.jar
    95067  10-11-2024 20:07   BOOT-INF/lib/spring-security-oauth2-jose-5.8.14.jar
    95083  10-11-2024 20:07   BOOT-INF/lib/spring-security-oauth2-core-5.8.14.jar
  1626085  10-11-2024 20:07   BOOT-INF/lib/spring-security-config-5.8.14.jar
    59629  10-11-2024 20:07   BOOT-INF/lib/spring-security-messaging-5.8.14.jar
   720854  10-11-2024 20:07   BOOT-INF/lib/spring-security-web-5.8.14.jar
   494843  10-10-2024 05:32   BOOT-INF/lib/spring-security-core-5.8.14.jar
    84315  10-11-2024 20:07   BOOT-INF/lib/spring-security-crypto-5.8.14.jar
    52411  10-11-2024 20:07   BOOT-INF/lib/spring-session-data-redis-2.7.4.jar
   447617  10-11-2024 20:07   BOOT-INF/lib/spring-websocket-5.3.39.jar
   568335  10-11-2024 20:07   BOOT-INF/lib/spring-messaging-5.3.39.jar
    39820  10-11-2024 20:07   BOOT-INF/lib/grails-spring-6.2.1.jar
  2143080  10-11-2024 20:07   BOOT-INF/lib/spring-data-redis-2.7.18.jar
   113576  10-11-2024 20:07   BOOT-INF/lib/spring-data-keyvalue-2.7.18.jar
  1348944  10-11-2024 20:07   BOOT-INF/lib/spring-data-commons-2.7.18.jar
   688403  10-10-2024 05:33   BOOT-INF/lib/spring-boot-actuator-2.7.18.jar
  1466652  10-10-2024 05:33   BOOT-INF/lib/spring-boot-2.7.18.jar
   792399  10-10-2024 05:33   BOOT-INF/lib/spring-test-5.3.39.jar
   204619  10-11-2024 20:07   BOOT-INF/lib/spring-orm-5.3.39.jar
   428714  10-10-2024 05:33   BOOT-INF/lib/spring-jdbc-5.3.39.jar
   333512  10-10-2024 05:33   BOOT-INF/lib/spring-tx-5.3.39.jar
  1030744  10-10-2024 05:33   BOOT-INF/lib/spring-webmvc-5.3.39.jar
   187183  10-10-2024 05:33   BOOT-INF/lib/spring-context-support-5.3.39.jar
  1276093  10-10-2024 05:33   BOOT-INF/lib/spring-context-5.3.39.jar
   385322  10-10-2024 05:33   BOOT-INF/lib/spring-aop-5.3.39.jar
  1660324  10-10-2024 05:33   BOOT-INF/lib/spring-web-5.3.39.jar
    65865  10-11-2024 20:07   BOOT-INF/lib/spring-oxm-5.3.39.jar
   706684  10-10-2024 05:33   BOOT-INF/lib/spring-beans-5.3.39.jar
   294249  10-10-2024 05:33   BOOT-INF/lib/spring-expression-5.3.39.jar
  1490485  10-10-2024 05:33   BOOT-INF/lib/spring-core-5.3.39.jar
    90865  10-11-2024 20:07   BOOT-INF/lib/spring-session-core-2.7.4.jar
    25161  10-10-2024 05:31   BOOT-INF/lib/spring-jcl-5.3.31.jar
    29514  10-11-2024 13:08   BOOT-INF/lib/spring-boot-jarmode-layertools-2.7.18.jar

@matrei
Copy link
Collaborator

matrei commented Oct 11, 2024

is that a good naming pattern? should jar name resolution be intuitive?

Probably not and preferably

having a module async seems prone to potential name clashes.

Yes

Are there any downsides to renaming these for Grails 7?

@codeconsole
Copy link
Contributor Author

@matrei I was just more looking to get async renamed, but if we are going to expand it to everything, we can push this back to 7.

@codeconsole codeconsole moved this to Todo in Grails 7 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Grails 7
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeconsole @matrei @jamesfredley