Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hamcrest to Match Spring Boot version #13828

Closed
codeconsole opened this issue Nov 9, 2024 · 1 comment
Closed

Update Hamcrest to Match Spring Boot version #13828

codeconsole opened this issue Nov 9, 2024 · 1 comment
Assignees

Comments

@codeconsole
Copy link
Contributor

codeconsole commented Nov 9, 2024

Feature description

Spring Boot uses Hamcrest 2.2 in Spring Boot 3.4.0

<hamcrest.version>2.2</hamcrest.version>

We only use hamcrest in ChainedTransactionManagerTests

ChainedTransactionManagerTests should be updated to work with the new version so that we no longer have to override the Spring version.

configurations.all {
resolutionStrategy {
force "org.hamcrest:hamcrest-core:1.3"
}
}

@codeconsole
Copy link
Contributor Author

codeconsole commented Nov 22, 2024

@bkoehm any chance you can update this 1 file to use hamcrest 2.2? The Grails bom extends the Spring bom so this is causing some issues and forcing us to use that configurations exclusion block. It would be really nice if you could just update the tests to use 2.2 which is the same version Spring uses.

Make sure to remove the exclusion block prior to upgrading. It is forcing version 1.3.

configurations.all {
resolutionStrategy {
force "org.hamcrest:hamcrest-core:1.3"
}
}

bkoehm added a commit to bkoehm/grails-core that referenced this issue Nov 22, 2024
codeconsole added a commit that referenced this issue Nov 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Grails 7 Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants