grails-gsp should not depend on codeconsole/grails-sitemesh3
#465
Comments
|
@matrei I believe this was done because there was a forced dependency for the constant for SiteMesh 2. Can you provide a code link to where the plugin is being required? |
|
Sure, here are links to the usages: |
matrei
changed the title
grails-gsp should not depend on codeconsole/sitemesh3-grails-plugingrails-gsp should not depend on codeconsole/grails-sitemesh3
|
@matrei thanks for that. It has been so long, I forgot I removed sitemesh2 from grails-gsp as well. The reason it was required is layouts are a fundamental part of Grails Web GSP and they will not work without SiteMesh or SiteMesh 3. SiteMesh 2 has always been a forced dependency. If we want to offer a version of grails that does not support layouts, we could remove the dependency. I don't have a problem with that. Another reason to not force SiteMesh 3 resolution would be if we decided to keep support for SiteMesh 2. |
|
sitemesh3-grails-plugin could also be brought in under grails-gsp repo |
`grails-gsp` should not depend on an external Grails Plugin. This dependency was only needed for a `String` constant: `org.grails.web.sitemesh.GroovyPageLayoutFinder.RENDERING_VIEW_ATTRIBUTE`. This commit removes the dependency by declaring the same constant in `GroovyPagesServlet` and using that instead. Closes #465
@codeconsole Yes, I think that makes sense, as sitemesh is such an integral part of Grails 👍 |
The dependency appears to be required solely for the
StringconstantRENDERING_VIEW_ATTRIBUTE.@codeconsole Could we either reverse this dependency or recreate the constant in
grails-gspto decouplegrails-gspfrom thegrails-sitemesh3plugin?The text was updated successfully, but these errors were encountered: