Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer placement is wrong #9

Open
fidotheprince opened this issue Jun 8, 2024 · 0 comments · Fixed by grantGCode/Fundamental-Web-Design-Landing-Page#17
Open

Footer placement is wrong #9

fidotheprince opened this issue Jun 8, 2024 · 0 comments · Fixed by grantGCode/Fundamental-Web-Design-Landing-Page#17
Assignees
Labels
help wanted Extra attention is needed

Comments

@fidotheprince
Copy link
Collaborator

The footer for the application is at the Page.js level, which is incorrect from a design perspective since the footer should be used globally across the entire site, e.g., at the Layout.js level.

The issue is that the footer form is dependent on it, which prevents us from adding it at the highest level of the application. The dependency must be on the client, but the Layout.js is a server component.

Therefore, we need to get the footer back at the layout level and remove the form from the footer, which would remove the dependency mentioned above.

We could add it to a section above the footer as a solution.

@fidotheprince fidotheprince added the help wanted Extra attention is needed label Jun 8, 2024
@fidotheprince fidotheprince pinned this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants