New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional documentation for `IterationState` in nanoDFT #70

Closed

hatemhelal opened this issue Sep 5, 2023 · 0 comments · Fixed by #71

Assignees

Contributor

hatemhelal commented Sep 5, 2023

The following attributes of the IterationState would benefit from having a meaningful doc string

pyscf-ipu/pyscf_ipu/nanoDFT/nanoDFT.py

Lines 143 to 146 in 2e9a440

    
                   input_floats (Array): 
        
                   input_ints (Array): 
        
                   L_inv (OrbitalMatrix): 
        
                   diis_history (Array):

The text was updated successfully, but these errors were encountered:

hatemhelal self-assigned this

hatemhelal linked a pull request

that will close this issue

adding doc strings for IterationState #71

Merged

hatemhelal closed this as completed in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment