Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate type annotations including the array shape in nanoDFT IterationState class #89

Open
hatemhelal opened this issue Sep 18, 2023 · 0 comments
Open

Incorporate type annotations including the array shape in nanoDFT IterationState class #89

hatemhelal opened this issue Sep 18, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@hatemhelal
Copy link
Contributor

In PR #71 we added additional type annotations to the IterationState class. Most of the fields of this data class are now annotated with a combined data type and tensor shape annotation. For example:

FloatNxN = Float[Array, "N N"]

This issue is to rationalise the remaining fields that are currently without a documented shape:

grid_weights
input_floats
input_ints
diis_history
@hatemhelal hatemhelal added the documentation Improvements or additions to documentation label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hatemhelal