Skip to content
This repository has been archived by the owner on Dec 21, 2020. It is now read-only.

Naming collision with "configuration" in the Ruby client #34

Open
RKushnir opened this issue Jan 25, 2019 · 1 comment
Open

Naming collision with "configuration" in the Ruby client #34

RKushnir opened this issue Jan 25, 2019 · 1 comment

Comments

@RKushnir
Copy link

RKushnir commented Jan 25, 2019

In the Ruby client there's 2 separate things that end up being named GraphHopperClient::Configuration:
https://github.com/graphhopper/directions-api-clients/blob/d69250ddf3c9280d0c61b6d85591650956455830/ruby/lib/directions-api-client/configuration.rb
and
https://github.com/graphhopper/directions-api-clients/blob/d69250ddf3c9280d0c61b6d85591650956455830/ruby/lib/directions-api-client/models/configuration.rb

As Ruby allows to re-open existing classes, there's no clear error message indicating this. These 2 things just get mixed together in an unexpected manner, making the gem unusable and failing with a confusing error.

@karussell
Copy link
Member

Uhm, this is ugly. This might be related or identical to the following issue of swagger codegen: swagger-api/swagger-codegen#8283

We are thinking about switching to the successor of swagger in this PR, but this is not yet properly planned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants