Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sophisticated preview of inactive numeral styles #15

Open
davelab6 opened this issue May 16, 2018 · 2 comments
Open

More sophisticated preview of inactive numeral styles #15

davelab6 opened this issue May 16, 2018 · 2 comments

Comments

@davelab6
Copy link

Some numeral features don't actually cause any changes from defaults.

Eg on https://graphicore.github.io/mdlFontSpecimen/ I see

screen shot 2018-05-16 at 15 10 11

Perhaps these should be colored grey, or otherwise indicated that nothing is actually happening... Or, the sample should show some context where the overall textblock uses another numeral style, and then a child span applies this feature.

@graphicore
Copy link
Owner

graphicore commented May 16, 2018

Yeah, that's in general the problem that we know what features are there but we don't have meaningful sample texts. Fishing for substitutions made by a feature is possible, but cumbersome and would produce nonsensical samples in many cases. When we know the font, we could put in the sample texts somewhere into the specimen options or markup.

Perhaps these should be colored grey, or otherwise indicated that nothing is actually happening

Hard to figure, I think there's no browser API that tells us if anything or what happened. I misread you, yeah we could grey them out manually.

Or, the sample should show some context where the overall textblock uses another numeral style, and then a child span applies this feature.

If this feature does nothing to numbers, why is it there in the first place?
feature creep (I thought this was funny in context of the nothing changing lnum feature. The request that is this issue is legit!)

I'm not sure if I get your proposal here. You mean the context would be onum and the sample would be not using onum, to imply what lnum would be doing if it would do anything?

We should maybe just remove the lnum tile?

@graphicore
Copy link
Owner

Updates in my first reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants