Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review responsive layouts (eg max-width) #7

Open
davelab6 opened this issue Dec 8, 2016 · 1 comment
Open

Review responsive layouts (eg max-width) #7

davelab6 opened this issue Dec 8, 2016 · 1 comment

Comments

@davelab6
Copy link

davelab6 commented Dec 8, 2016

I chatted with @yuinchien today and she requested to review the page in Chromium Web Inspector's mobile/tablet preview modes and check how it works in various viewport sizes, and add some more responsive CSS rules to improve it - for example, on a desktop with a wide viewport the page lacks max-width rules that make its contents become very wide and unsightly.

@graphicore
Copy link
Owner

I improved some aspects here:

  • max-width is now at 1900px.
  • For the Chromium Web Inspector's mobile/tablet preview to work I had to add the tag <meta name="viewport" content="width=device-width, initial-scale=1" />, which I though I had already there, sorry for the inconvenience.
    I didn't add too many new responsive CSS rules, most of the existing ones weren't triggered in that preview mode due to the missing meta tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants