-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRST audit fixes for HorizonStaking contract #1073
Open
Maikol
wants to merge
21
commits into
horizon
Choose a base branch
from
mde/trust-staking-fixes
base: horizon
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRST audit fixes for HorizonStaking contract
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Maikol
force-pushed
the
mde/trust-staking-fixes
branch
from
November 28, 2024 16:29
9e05f2f
to
edb248c
Compare
Maikol
force-pushed
the
mde/trust-staking-fixes
branch
from
November 28, 2024 18:26
edb248c
to
ce749be
Compare
Maikol
changed the title
fix: separate delegation and provision thaw request lists (TRST-H02)
TRST audit fixes for HorizonStaking contract
Dec 2, 2024
tmigone
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions!
pcarranzav
reviewed
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
TRST-H-2 Core thawing logic of Horizon staking can be broken due to collision in data structures
TRST-H-3 An attacker could prevent a delegator from ever withdrawing their tokens
TRST-H-4 The last withdrawal from a provision or delegation could permanently revert due to accounting flaw in slashing
TRST-H-6 During the transition period, legacy allocations cannot be slashed
TRST-H-7 Delegators that began undelegation before the transition would not be able to withdraw them
TRST-M-3 An attacker could make the minimum delegation amount arbitrarily large and prevent competing delegations
TRST-M-11 After the transition period, locked amount would still not be available for use
TRST-M-12 The operator check in closeAllocations() will not work, indexers must close by themselves
TRST-L-3 The getThawedTokens() function could return a wrong amount leading to integration risks
TRST-R-1 Improve event structure
TRST-R-7 Thawing shares should be rounded up to protect from early unlocking of tokens
TRST-R-9 Documentation errors