Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should not allow to vote on a challenge if that tx is going to fail #194

Open
d10r opened this issue Oct 23, 2020 · 1 comment
Open

Comments

@d10r
Copy link

d10r commented Oct 23, 2020

I just created a challenge in https://everest.link/project/0xe265942ad988d0c8512a92fac73d124389362191/
Afterwards, I was presented with this view:
image

The buttons "Keep" and "Remove" are active, so I clicked "Remove", not knowing that creating a challenge already counts as a "Remove" vote (as I now assume).
Next I cloud select a project on behalf of which I wanted to vote. I selected and confirmed.
Metamask didn't complain and let me send the tx. Which then failed: https://etherscan.io/tx/0xb4062ed4048beed1723c2678e2b4f05d0e107a1973be5e02bbc6220480ca19d6

The UI should not allow casting a vote in such a case.

PS: I also wonder why challenges and votes on them are to be expressed on behalf of a project. Why can't I do that simply as a registry curator, independent of a project?

@andromedapool
Copy link

Agree on the fact that the buttons should have different states based on the actions that the user took. Also after you vote to keep/remove, the buttons don't reflect this in any manner.

@d10r Regarding to your question, why voting is done on behalf of a project, it is explained in the most recent curator call, link here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants