fix(executor-http): avoid shared AbortController in Cloudflare Workers
#1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the HTTP executor where a shared AbortController causes "Cannot perform I/O on behalf of a different request" errors in Cloudflare Workers environments. The fix conditionally creates the AbortController based on the runtime environment and handles the case where it may be undefined.
Key changes:
- Conditionally create
AbortControllerto avoid Cloudflare Workers compatibility issues - Add null-safe checks for
disposeCtrlthroughout the affected code paths - Handle empty signals array when creating the combined abort signal
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/executors/http/src/index.ts | Implements conditional AbortController creation and adds null-safety checks |
| .changeset/lovely-coins-dream.md | Documents the bug fix for Cloudflare Workers compatibility |
Collaborator
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-tools/batch-delegate |
10.0.5-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/batch-execute |
10.0.4-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/delegate |
11.1.3-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/executor-common |
1.0.5-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/executor-graphql-ws |
3.1.3-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/executor-http |
3.0.7-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/federation |
4.2.3-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/fusion-runtime |
1.5.1-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway |
2.1.17-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/logger |
1.0.9-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
2.0.22-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-aws-sigv4 |
2.0.17-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-deduplicate-request |
2.0.8-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/hmac-upstream-signature |
2.0.8-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-opentelemetry |
1.1.3-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
2.1.3-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/router-runtime |
1.0.1-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-runtime |
2.3.5-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitch |
10.1.3-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitching-directives |
4.0.5-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-testing |
2.0.5-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-common |
1.0.12-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-http |
1.0.12-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-http-callback |
1.0.12-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-ws |
2.0.12-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/wrap |
11.0.5-alpha-5b67375ca958b3783f916540e762f1b25ba53856 |
npm ↗︎ unpkg ↗︎ |
Collaborator
🚀 Snapshot Release (Binary for
|
Collaborator
🚀 Snapshot Release (Binary for
|
Collaborator
🚀 Snapshot Release (Binary for
|
Collaborator
🚀 Snapshot Release (Binary for
|
Collaborator
🚀 Snapshot Release (Binary for
|
Collaborator
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
Collaborator
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
enisdenjo
approved these changes
Jul 22, 2025
Member
enisdenjo
left a comment
enisdenjo
left a comment
There was a problem hiding this comment.
Let's wait for the user to test and merge then.
ardatan
force-pushed
the
avoid-shared-ctrl-incf
branch
2 times, most recently
from
01fe358 to
207e397
Compare
ardatan
force-pushed
the
avoid-shared-ctrl-incf
branch
from
207e397 to
5b67375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ardatan/graphql-mesh#8691