From f873cbe0cecb1cd4f7132909e6cdbfaba1b6c15c Mon Sep 17 00:00:00 2001 From: Roman Tkachenko Date: Wed, 21 Dec 2022 17:44:11 -0800 Subject: [PATCH] Fix skipped but required checks for Github Actions (#19594) --- .github/workflows/build-macos-bypass.yaml | 2 +- .github/workflows/build-macos.yaml | 2 +- .github/workflows/build-windows-bypass.yaml | 2 +- .github/workflows/build-windows.yaml | 2 +- .github/workflows/integration-tests-non-root-bypass.yaml | 2 +- .github/workflows/integration-tests-root-bypass.yaml | 2 +- .github/workflows/os-compatibility-test.yaml | 6 +++--- .github/workflows/unit-tests-code-bypass.yaml | 2 +- .github/workflows/unit-tests-helm-bypass.yaml | 2 +- .github/workflows/unit-tests-operator-bypass.yaml | 2 +- .github/workflows/unit-tests-rust-bypass.yaml | 2 +- api/client/proxy.go | 3 ++- api/types/authority.go | 4 ++-- lib/srv/desktop/rdp/rdpclient/src/piv.rs | 4 ++-- 14 files changed, 19 insertions(+), 18 deletions(-) diff --git a/.github/workflows/build-macos-bypass.yaml b/.github/workflows/build-macos-bypass.yaml index e2931f6f2a1cc..4fe67a8f3cfbe 100644 --- a/.github/workflows/build-macos-bypass.yaml +++ b/.github/workflows/build-macos-bypass.yaml @@ -23,7 +23,7 @@ on: jobs: build: - name: Skipped + name: Build on Mac OS runs-on: macos-12 permissions: diff --git a/.github/workflows/build-macos.yaml b/.github/workflows/build-macos.yaml index 55af74bcb294c..26d9a39bd7ff5 100644 --- a/.github/workflows/build-macos.yaml +++ b/.github/workflows/build-macos.yaml @@ -16,7 +16,7 @@ on: jobs: build: - name: Build all tools on Mac OS + name: Build on Mac OS runs-on: macos-12 # TODO(r0mant): Update with large runner when it's available permissions: diff --git a/.github/workflows/build-windows-bypass.yaml b/.github/workflows/build-windows-bypass.yaml index 1b2d666a7c230..4274d3f480ba1 100644 --- a/.github/workflows/build-windows-bypass.yaml +++ b/.github/workflows/build-windows-bypass.yaml @@ -22,7 +22,7 @@ on: jobs: build: - name: Skipped + name: Build on Windows runs-on: windows-latest permissions: diff --git a/.github/workflows/build-windows.yaml b/.github/workflows/build-windows.yaml index 53ee6ae7b52a7..4d6ed2c5da232 100644 --- a/.github/workflows/build-windows.yaml +++ b/.github/workflows/build-windows.yaml @@ -15,7 +15,7 @@ on: jobs: build: - name: Build tsh tool on Windows + name: Build on Windows runs-on: windows-2022-16core permissions: diff --git a/.github/workflows/integration-tests-non-root-bypass.yaml b/.github/workflows/integration-tests-non-root-bypass.yaml index e2aadf1d329e9..ca5485fca2dfb 100644 --- a/.github/workflows/integration-tests-non-root-bypass.yaml +++ b/.github/workflows/integration-tests-non-root-bypass.yaml @@ -20,7 +20,7 @@ on: jobs: test: - name: Skipped + name: Integration Tests (Non-root) runs-on: ubuntu-latest permissions: diff --git a/.github/workflows/integration-tests-root-bypass.yaml b/.github/workflows/integration-tests-root-bypass.yaml index 0b613031531e9..9a19587093678 100644 --- a/.github/workflows/integration-tests-root-bypass.yaml +++ b/.github/workflows/integration-tests-root-bypass.yaml @@ -20,7 +20,7 @@ on: jobs: test: - name: Skipped + name: Integration Tests (Root) runs-on: ubuntu-latest permissions: diff --git a/.github/workflows/os-compatibility-test.yaml b/.github/workflows/os-compatibility-test.yaml index 62489076f4ecc..876f9fe982f18 100644 --- a/.github/workflows/os-compatibility-test.yaml +++ b/.github/workflows/os-compatibility-test.yaml @@ -8,7 +8,7 @@ on: jobs: build: - name: Build Artifacts + name: OS Compatibility Build runs-on: ubuntu-22.04-16core permissions: @@ -28,7 +28,7 @@ jobs: - name: Run make run: | - make build/tctl build/tsh build/tbot build/teleport + make binaries - name: Upload binaries uses: actions/upload-artifact@v3 @@ -38,7 +38,7 @@ jobs: test-compat: needs: build - name: Run Compatibility Test + name: OS Compatibility Test runs-on: ubuntu-latest permissions: diff --git a/.github/workflows/unit-tests-code-bypass.yaml b/.github/workflows/unit-tests-code-bypass.yaml index dacb147d6fa67..42f7ee3756e37 100644 --- a/.github/workflows/unit-tests-code-bypass.yaml +++ b/.github/workflows/unit-tests-code-bypass.yaml @@ -18,7 +18,7 @@ on: jobs: test: - name: Skipped + name: Unit Tests (Go) runs-on: ubuntu-latest permissions: diff --git a/.github/workflows/unit-tests-helm-bypass.yaml b/.github/workflows/unit-tests-helm-bypass.yaml index b7a7fbdc5aabb..80ff10fe8a1cb 100644 --- a/.github/workflows/unit-tests-helm-bypass.yaml +++ b/.github/workflows/unit-tests-helm-bypass.yaml @@ -18,7 +18,7 @@ on: jobs: test: - name: Skipped + name: Unit Tests (Helm) runs-on: ubuntu-latest permissions: diff --git a/.github/workflows/unit-tests-operator-bypass.yaml b/.github/workflows/unit-tests-operator-bypass.yaml index 19669eb66deb5..037c001eae503 100644 --- a/.github/workflows/unit-tests-operator-bypass.yaml +++ b/.github/workflows/unit-tests-operator-bypass.yaml @@ -22,7 +22,7 @@ on: jobs: test: - name: Skipped + name: Unit Tests (Operator) runs-on: ubuntu-latest permissions: diff --git a/.github/workflows/unit-tests-rust-bypass.yaml b/.github/workflows/unit-tests-rust-bypass.yaml index ebcd6be9a11ed..443069a1918c9 100644 --- a/.github/workflows/unit-tests-rust-bypass.yaml +++ b/.github/workflows/unit-tests-rust-bypass.yaml @@ -20,7 +20,7 @@ on: jobs: test: - name: Skipped + name: Unit Tests (Rust) runs-on: ubuntu-latest permissions: diff --git a/api/client/proxy.go b/api/client/proxy.go index e272ff5989fa9..49f97588ecffb 100644 --- a/api/client/proxy.go +++ b/api/client/proxy.go @@ -33,7 +33,8 @@ func DialProxy(ctx context.Context, proxyURL *url.URL, addr string) (net.Conn, e return DialProxyWithDialer(ctx, proxyURL, addr, &net.Dialer{}) } -// DialProxyWithDialer creates a connection to a server via an HTTP or SOCKS5 Proxy using a specified dialer. +// DialProxyWithDialer creates a connection to a server via an HTTP or SOCKS5 +// Proxy using a specified dialer. func DialProxyWithDialer( ctx context.Context, proxyURL *url.URL, diff --git a/api/types/authority.go b/api/types/authority.go index 007bc017a6b7e..b3286d8ee8085 100644 --- a/api/types/authority.go +++ b/api/types/authority.go @@ -27,8 +27,8 @@ import ( "github.com/gravitational/teleport/api/constants" ) -// CertAuthority is a host or user certificate authority that -// can check and if it has private key stored as well, sign it too +// CertAuthority is a host or user certificate authority that can check and if +// it has private key stored as well, sign it too. type CertAuthority interface { // ResourceWithSecrets sets common resource properties ResourceWithSecrets diff --git a/lib/srv/desktop/rdp/rdpclient/src/piv.rs b/lib/srv/desktop/rdp/rdpclient/src/piv.rs index b058ae34c1152..0b2ca009a842c 100644 --- a/lib/srv/desktop/rdp/rdpclient/src/piv.rs +++ b/lib/srv/desktop/rdp/rdpclient/src/piv.rs @@ -45,8 +45,8 @@ pub struct Card { piv_auth_cert: Vec, piv_auth_key: RsaPrivateKey, pin: String, - // Pending command and response to receive/send over multiple messages when they don't fit into - // one. + // Pending command and response to receive/send over multiple messages when + // they don't fit into one. pending_command: Option>, pending_response: Option>>, }