Validate autoupdate_config and autoupdate_agent_rollout #50181
+1,065
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
changed the title
sclevine
reviewed
Dec 13, 2024
| } | ||
|
|
||
| var maxGroups int | ||
| isCloud := modules.GetModules().Features().Cloud |
There was a problem hiding this comment.
We may want to relax these restrictions for some Cloud customers on a case-by-case basis. Would it be tricky to add an "unrestricted" feature? (Could be a separate PR)
There was a problem hiding this comment.
We will likely want to rely on entitlements. I'm not familiar with this mechanism and will have to ask cloud devs how to do this. If it's not easy, I'll just glue an ugly environment variable so we are not blocked.
sclevine
approved these changes
Dec 13, 2024
hugoShaka
force-pushed
the
hugo/autoupdate_config-validation
branch
from
f7451c1 to
3a91f1b
Compare
vapopov
approved these changes
Dec 13, 2024
hugoShaka
force-pushed
the
hugo/autoupdate_config-validation
branch
from
3a91f1b to
2966633
Compare
sclevine
approved these changes
Dec 16, 2024
| return trace.BadParameter("max groups (%d) exceeded for strategy %s, %s schedule contains %d groups", maxGroups, agentsSpec.GetStrategy(), update.AgentsScheduleRegular, len(agentsSpec.GetSchedules().GetRegular())) | ||
| } | ||
|
|
||
| if isCloud { |
There was a problem hiding this comment.
Suggested change
| if isCloud { | |
| if !isCloud { | |
| return nil | |
| } |
nit: cleans up indent a bit
vapopov
approved these changes
Dec 16, 2024
| @@ -47,7 +47,8 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| defaultUpdateDays = []string{"Mon", "Tue", "Wed", "Thu"} | |||
| // DefaultUpdateDays is the default list of days when groups can be updated. | |||
| DefaultUpdateDays = []string{"Mon", "Tue", "Wed", "Thu"} | |||
There was a problem hiding this comment.
hope its not going to be modified externally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: RFD-184
Goal (internal): https://github.com/gravitational/cloud/issues/10289
This PR removes the restrictions of the
autoupdate_agent_rolloutandautoupdate_configschedules but adds groups validation.It also adds some optional server-side validation that should not be enforced at the resource level.