-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Netclient version 0.30 using 443 as port is not a good idea ? #3262
Comments
okay I read the changelog.
soooo. the whole world is running https services on this port. |
netclient will only use 443 if it's free otherwise defaults to 51821 and it only listens on private IP |
I suggest to change this. Many automations might try to deploy to 443 a few seconds or minutes later. Or users sometime else and then they need to find and change the netclient port (which does not have a setting to even change it ?) Also so many firewalls are akready preset to the netmaker ports. They all have to change now... I love the product and I love you guys but please think this over 🙂 We have so many ports. Also such a change should really be announced some time upfront. 51821 was really fine. and only need one port ist also amazing. But should stick to what has been preset. IMHO 🙂 My docker deployments did not like it...even though yes. It should only listen to a private port? Port 51821 was already becoming associated with the netmaker brand too. Kinda. |
And I suggest adding the IP that it is going to connect to (in my case 10.10.2.18) to the server UI so it is immediately evident. And to the |
This won't affect existing netclients only for new clients, netclient also has the option to specify port while joining the network or you can also change it in the UI |
It affects them as soon as they update in automated deployments. This is a enterprise product, you are otherweise expecting users to go into the ui and change stuff there. really?
If you have such an environment you are either the admin and know how to adjust or you do not have any business deploying nm there in the first place. I was able to fix my deployments by specifying the port. The risks are way bigger than any value provided. |
Yes, I know this is an enterprise product and our enterprise customers requested that we reduce the port requirements to a single port preferably to 443. We have built the client to be configurable, and all you need to do is add your desired port in the cmd argument while joining the network. If users are facing any issues with this change we are happy to revert the change |
I fully understand and it's a good change but FORCING the 443 is kinda the issue. Thank you for taking the time to reply. I found netclient list now has more output too which broke all my parsers. That's okay :-) cheers |
Nobody FORCING you set the port as 443, it is just the port that the client will use if available and you have an OPTION to use a different port. NOBODY is FORCING you to use the port mentioned. there were no changes made to the netclient list cmd, what more output? |
Using port 443 by default is a bad choice for all the reasons @cocoonkid has explained already. I was also bitten by this regression and therefore found this ticket. The default port should be reverted back to what it was before: 51821 - 51830 (the first free port). |
Contact Details
No response
What happened?
Not part fo my actual netclient network.
What network is this ?
Version
v0.26.0
What OS are you using?
No response
Relevant log output
No response
Contributing guidelines
The text was updated successfully, but these errors were encountered: