fix(ChangelogDialog): fix sb

gravity-ui · Nov 10, 2023 · e8e8b0f · e8e8b0f
1 parent 8b891ac
commit e8e8b0f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/src/components/ChangelogDialog/ChangelogDialog.tsx b/src/components/ChangelogDialog/ChangelogDialog.tsx
@@ -43,7 +43,7 @@ export function ChangelogDialog({
     onClose,
     onStoryClick,
     onLinkClick,
-    loading = true,
+    loading,
 }: ChangelogDialogProps) {
     const idRef = React.useRef<number>();
     idRef.current = idRef.current || getNextId();

diff --git a/src/components/ChangelogDialog/__stories__/ChangelogDialog.stories.tsx b/src/components/ChangelogDialog/__stories__/ChangelogDialog.stories.tsx
@@ -1,4 +1,4 @@
-import React, {useEffect} from 'react';
+import React from 'react';
 
 import {Button} from '@gravity-ui/uikit';
 import type {Meta, StoryFn} from '@storybook/react';
@@ -79,22 +79,11 @@ const items: ChangelogItem[] = [
 
 const DefaultTemplate: StoryFn<ChangelogDialogProps> = (props: ChangelogDialogProps) => {
     const [visible, setVisible] = React.useState(props.open);
-    const [loading, setLoading] = React.useState(true);
 
     React.useEffect(() => {
         setVisible(props.open);
     }, [props.open]);
 
-    useEffect(() => {
-        if (!visible) return;
-        const timeoutId = setTimeout(() => setLoading(false), 1000);
-        // eslint-disable-next-line consistent-return
-        return () => {
-            clearTimeout(timeoutId);
-            setLoading(true);
-        };
-    }, [visible]);
-
     return (
         <React.Fragment>
             <div>
@@ -109,7 +98,6 @@ const DefaultTemplate: StoryFn<ChangelogDialogProps> = (props: ChangelogDialogPr
             <ChangelogDialog
                 {...props}
                 open={visible}
-                loading={loading}
                 onClose={(event, reason) => {
                     setVisible(false);
                     props.onClose?.(event, reason);