Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the feature to support theme for button in Banner block and align for image (i.e. left, center, right) #787

Closed
VitaliiDC8 opened this issue Jan 29, 2024 · 3 comments
Closed

Add the feature to support theme for button in Banner block and align for image (i.e. left, center, right) #787

VitaliiDC8 opened this issue Jan 29, 2024 · 3 comments

Comments

@VitaliiDC8
Copy link
Contributor

VitaliiDC8 commented Jan 29, 2024 •
edited
Loading

Image should be aligned to left/center/right, because after changing page size we want to able to user focus on specific part of image.
image
image
image
@stepastepastepa
Copy link

stepastepastepa commented Jan 30, 2024 •
edited
Loading

How will this be indicated in the backoffice markup? Сould there be a need to do this vertically too? For example: top; bottom.

We have a MediaView: fit/fill setting in the HeaderBlock https://preview.gravity-ui.com/page-constructor/?path=/story/blocks-header--media-view-fit. Maybe this setting will be useful to you? It's not there now, but it can be reused.

It would be good to implement this within the same approach for similar cases.

@VitaliiDC8
Copy link
Contributor Author

#794

@VitaliiDC8 VitaliiDC8 mentioned this issue Jan 31, 2024
Merged
@VitaliiDC8
Copy link
Contributor Author

How will this be indicated in the backoffice markup? Сould there be a need to do this vertically too? For example: top; bottom.

We have a MediaView: fit/fill setting in the HeaderBlock https://preview.gravity-ui.com/page-constructor/?path=/story/blocks-header--media-view-fit. Maybe this setting will be useful to you? It's not there now, but it can be reused.

It would be good to implement this within the same approach for similar cases.

ok, we can use MediaView like in Header block, this is acceptable for our requirments. full will work like it works right now. Fit - media content has real sizes and locates in the middle

VitaliiDC8 added a commit that referenced this issue Feb 2, 2024
@VitaliiDC8
feat: added mediaView for image and theme for button in banner block (#…
4be4bc9 
…794)

Features
* add theme to button in banner-block (#787)
* add mediaView (`full | fit` — full is default value, the media content covers all width and height. Fit - media content has real sizes and locates in the middle) to image in banner-block (#787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NikitaCG @stepastepastepa @VitaliiDC8