-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to place card controls (links & buttons) in a card footer #826
Comments
@DC-RomanKarpov does this only work for specific cards? We need to remove this property from the background card and add it to the image card. Have we touched the original content component? I see that the layout of the buttons has changed at least. |
Hey, @stepastepastepa ! Yes, the Content was touched: some parts of that component was separated to Buttons & Links components. Will double check that layout will not change. Edit: Checked. Do not see the difference on screenshot tests. Could you point the exact place, please? |
@DC-RomanKarpov Yes, you're right. There are no buttons. Then we don't touch that place. To the account of the background-card. Is it possible to use the new parameter only if we do not specify paddingBottom? When this parameter is present, the alignment looks very strange. It is necessary to make such a combination impossible to assemble. Could we do that? There are no visual changes. I noticed because now the indentation is implemented differently. I just need to understand exactly what we have touched on in order to check other cases. Everything is ok now. |
For the bg-card - yes, we can manage the desired behavior easily. For the changes - all margins for buttons was removed. |
good, thx |
This feature is required by our content managers to align all control in cards, for example, see the attached screenshots.
For impl example, please, see
https://preview.gravity-ui.com/page-constructor/823/?path=/story/components-cards-backgroundcard--control-position
https://preview.gravity-ui.com/page-constructor/823/?path=/story/components-cards-basiccard--control-position
https://preview.gravity-ui.com/page-constructor/823/?path=/story/components-cards-layoutitem--control-position
The text was updated successfully, but these errors were encountered: