feat: brand footer #1084
Merged
feat: brand footer #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PahaN47
requested review from
gorgeousvlad,
NikitaCG and
aeksandla
as code owners
|
Preview is ready. |
aeksandla
previously approved these changes
Nov 28, 2024
NikitaCG
requested changes
Nov 28, 2024
| @@ -50,6 +51,7 @@ export interface PageConstructorProps { | |||
| custom?: CustomConfig; | |||
| renderMenu?: () => React.ReactNode; | |||
| navigation?: NavigationData; | |||
| branded?: boolean; | |||
There was a problem hiding this comment.
isBranded
and add info in readme https://github.com/gravity-ui/page-constructor/blob/main/README.md#L42
aeksandla
previously approved these changes
Dec 2, 2024
NikitaCG
requested changes
Dec 2, 2024
src/icons/BrandIcon.tsx
Outdated
| import {a11yHiddenSvgProps} from '../utils/svg'; | ||
|
|
||
| export const BrandIcon: React.FC<React.SVGProps<SVGSVGElement>> = (props) => { | ||
| const theme = useTheme(); |
There was a problem hiding this comment.
it seems to me that we need to create two icons and decide which one to use in this place. I think it will be more obvious why it is changing.
NikitaCG
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.