Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withTableSelection HOC does not color rows background #1395

Closed
korvin89 opened this issue Mar 4, 2024 · 5 comments
Closed

withTableSelection HOC does not color rows background #1395

korvin89 opened this issue Mar 4, 2024 · 5 comments
Assignees
Labels
bug Something isn't working component: Table

Comments

@korvin89
Copy link
Contributor

korvin89 commented Mar 4, 2024

It broke down here. In the previous PR it worked. We need to add screenshot test for this case.

@korvin89 korvin89 added bug Something isn't working component: Table labels Mar 4, 2024
@korvin89
Copy link
Contributor Author

korvin89 commented Mar 4, 2024

@GermanVor @Raubzeug Hey! Could you check this problem?

@GermanVor
Copy link
Contributor

GermanVor commented Mar 4, 2024

Did I understand correctly ?

how it should looks like:
image

and how it looks like now (we want this bg color):
image

@korvin89

@korvin89
Copy link
Contributor Author

korvin89 commented Mar 4, 2024

Did I understand correctly ?

how it should looks like: image

and how it looks like now (we want this bg color): image

@korvin89

@GermanVor Yep

@GermanVor
Copy link
Contributor

GermanVor commented Mar 4, 2024

fix is ready - #1397

Did not add screenshot test - do not know how.
If it's not difficult, please give me an example and I can do it in another PR.

@korvin89

@korvin89
Copy link
Contributor Author

korvin89 commented Mar 5, 2024

fix is ready - #1397

Did not add screenshot test - do not know how. If it's not difficult, please give me an example and I can do it in another PR.

@korvin89

You can check example here. It is not required but will be great to add this tests a little bit later

@amje amje closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: Table
Projects
None yet
Development

No branches or pull requests

4 participants