Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation does not match components #1574

Closed
SimbiozizV opened this issue May 9, 2024 · 1 comment
Closed

Documentation does not match components #1574

SimbiozizV opened this issue May 9, 2024 · 1 comment
Labels
component: Link documentation Improvements or additions to documentation

Comments

@SimbiozizV
Copy link

I encountered that the properties of the Link component do not correspond to the documentation on the site https://gravity-ui.com/components/uikit/link

Previously, the href property was optional and this was indicated in the documentation, but with pr #1270 this has changed.

There is no documentation for version 6.15.0 and it is a bit misleading.
@korvin89 korvin89 added documentation Improvements or additions to documentation component: Link labels May 13, 2024
@korvin89
Copy link
Contributor

@SimbiozizV Hey! It is indicated here, but there is one inaccuracy in properties table, we will fix it

saripovdenis added a commit to saripovdenis/uikit that referenced this issue May 18, 2024
@saripovdenis
fix(Link): change href property type description (gravity-ui#1574)
5f05cf5
korvin89 added a commit that referenced this issue May 20, 2024
@saripovdenis @korvin89
fix(Link): change href property type description (#1574) (#1593)
0aec983 
Co-authored-by: Mr.Dr.Professor Patrick <[email protected]>
@gravity-ui-bot gravity-ui-bot mentioned this issue May 20, 2024
Merged
@amje amje closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: Link documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amje @SimbiozizV @korvin89