Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: Allow text/ReactNode counter in TabItem #1983

Closed
EgorKluch opened this issue Dec 9, 2024 · 1 comment · Fixed by #1989
Closed

Tabs: Allow text/ReactNode counter in TabItem #1983

EgorKluch opened this issue Dec 9, 2024 · 1 comment · Fixed by #1989

Comments

@EgorKluch
Copy link
Contributor

https://github.com/gravity-ui/uikit/blob/main/src/components/Tabs/TabsItem.tsx#L103

It's need for example to show '99+' count.
@EgorKluch EgorKluch linked a pull request Dec 12, 2024 that will close this issue
feat(Tabs): allow string for TabItem counter value #1989
Merged
@EgorKluch
Copy link
Contributor Author

I thought about the problem. I can't imagine cases why we need something more then number or string for counter. So, I allow only number | string for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Tabs): allow string for TabItem counter value gravity-ui/uikit
1 participant
@EgorKluch