feat(Table): add filter to colum settings #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
amje
requested changes
Jun 4, 2024
Raubzeug
requested changes
Jun 6, 2024
| @@ -242,6 +246,17 @@ const mapItemDataToProps = (item: TableColumnSetupItem): ListItemCommonProps => | |||
| }; | |||
| }; | |||
|
|
|||
| const defaultFilterItemsFn = (item: TableColumnSetupItem, value: string) => { | |||
| return typeof item.title === 'string' | |||
| ? item.title.toLowerCase().includes(value.toLowerCase()) | |||
| @@ -242,6 +246,17 @@ const mapItemDataToProps = (item: TableColumnSetupItem): ListItemCommonProps => | |||
| }; | |||
| }; | |||
|
|
|||
| const defaultFilterItemsFn = (item: TableColumnSetupItem, value: string) => { | |||
There was a problem hiding this comment.
may be it's passible to use useListFilter from this example and not realise filtration logic from stretch?
it is also welcome for the development of a hook component for filtering
@polikashina @amje @Raubzeug What do you think?
|
Visual Tests Report is ready. |
amje
requested changes
Jun 8, 2024
src/components/Table/hoc/withTableSettings/TableColumnSetup/TableColumnSetup.tsx
Show resolved
Hide resolved
|
Can we remove the delay? 2024-06-08.22.53.39.mov |
There is a delay because of debounce. It is possible to set it to |
Let's set to 0. There is no reason to wait user finishes input |
polikashina
force-pushed
the
filterable-table-settings
branch
from
e839ec9 to
6e70da7
Compare
amje
changed the title
amje
approved these changes
Jun 11, 2024
Raubzeug
approved these changes
Jun 12, 2024
IsaevAlexandr
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added search for column settings for withTableSettings HOC
https://st.yandex-team.ru/UXRFC-485