From 17c9eddd5b369bd9da9d5597fef8428f19d8d80f Mon Sep 17 00:00:00 2001 From: Saif Sultan Date: Mon, 18 Dec 2023 22:41:47 +0530 Subject: [PATCH 1/2] `gw-choice-counter.php`: Fixed an issue with Multi Select field not working on the same choice field ids. --- gravity-forms/gw-choice-counter.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gravity-forms/gw-choice-counter.php b/gravity-forms/gw-choice-counter.php index dbd5a6211..dd0ec126d 100644 --- a/gravity-forms/gw-choice-counter.php +++ b/gravity-forms/gw-choice-counter.php @@ -73,8 +73,11 @@ function output_script() { $choiceField = $(choiceFieldSelector), $parentForm = $choiceField.parents('form'); - $parentForm.off( 'click', choiceFieldSelector, self.updateChoiceEventHander ); - $parentForm.off( 'change', choiceFieldSelector, self.updateChoiceEventHander ); + // Do not disable previous select event for multi-select because we may have multiple instances on same choice fields. + if ( $choiceField.attr('multiple') !== 'multiple' ) { + $parentForm.off( 'click', choiceFieldSelector, self.updateChoiceEventHander ); + $parentForm.off( 'change', choiceFieldSelector, self.updateChoiceEventHander ); + } if ( self.isCheckableField( $choiceField ) ) { $parentForm.on( 'click', choiceFieldSelector, self.updateChoiceEventHandler ); From 978681a2ace81ad79752b6d39cee3f27f6f03dbb Mon Sep 17 00:00:00 2001 From: Saif Sultan Date: Tue, 19 Dec 2023 18:55:56 +0530 Subject: [PATCH 2/2] `gw-choice-counter.php`: Fixed an issue with Multi Select field not working on the same choice field ids. --- gravity-forms/gw-choice-counter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gravity-forms/gw-choice-counter.php b/gravity-forms/gw-choice-counter.php index dd0ec126d..99fe281e8 100644 --- a/gravity-forms/gw-choice-counter.php +++ b/gravity-forms/gw-choice-counter.php @@ -74,7 +74,7 @@ function output_script() { $parentForm = $choiceField.parents('form'); // Do not disable previous select event for multi-select because we may have multiple instances on same choice fields. - if ( $choiceField.attr('multiple') !== 'multiple' ) { + if ( $choiceField.attr('multiple') !== 'multiple' && !Boolean( $choiceField.find(':checkbox').length ) ) { $parentForm.off( 'click', choiceFieldSelector, self.updateChoiceEventHander ); $parentForm.off( 'change', choiceFieldSelector, self.updateChoiceEventHander ); }