Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about Contributions #107

Open
MatthewWest opened this issue Aug 10, 2016 · 1 comment
Open

Questions about Contributions #107

MatthewWest opened this issue Aug 10, 2016 · 1 comment

Comments

@MatthewWest
Copy link

MatthewWest commented Aug 10, 2016

Before contributing I wanted to find out a few details:

  • What Python versions does this library target? For instance, is it OK to migrate from the commands module (deprecated since 2.6, not included in 3+) to the subprocess module?
  • Are changes to bring the library inline with PEP8 welcome? (by their nature, they'll have a lot of changed lines, as they are formatting changes)
@alexanderhiam
Copy link
Member

Contributions are certainly welcome, and considering I've been so busy that I'm just now getting around to responding to this issue, contributions would be extra appreciated at the moment!

I'm targeting 2.7, and I plan to continue unless someone has a very compelling reason to switch to 3+.

I'm not against changes to make PyBBIO PEP8 compliant, it seems like a lot of people would prefer that. But since they'd be big changes touching most lines of code (I much prefer 2 spaces / tab), I'd probably want to see per file commits, and maybe even per change per file (e.g. a commit for PEP8 whitespace compliance in xyz.py). That way merging would be pretty painless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants