You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before contributing I wanted to find out a few details:
What Python versions does this library target? For instance, is it OK to migrate from the commands module (deprecated since 2.6, not included in 3+) to the subprocess module?
Are changes to bring the library inline with PEP8 welcome? (by their nature, they'll have a lot of changed lines, as they are formatting changes)
The text was updated successfully, but these errors were encountered:
Contributions are certainly welcome, and considering I've been so busy that I'm just now getting around to responding to this issue, contributions would be extra appreciated at the moment!
I'm targeting 2.7, and I plan to continue unless someone has a very compelling reason to switch to 3+.
I'm not against changes to make PyBBIO PEP8 compliant, it seems like a lot of people would prefer that. But since they'd be big changes touching most lines of code (I much prefer 2 spaces / tab), I'd probably want to see per file commits, and maybe even per change per file (e.g. a commit for PEP8 whitespace compliance in xyz.py). That way merging would be pretty painless.
Before contributing I wanted to find out a few details:
commands
module (deprecated since 2.6, not included in 3+) to thesubprocess
module?The text was updated successfully, but these errors were encountered: