Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTHER] Fixup warnings from jest/max-nested-describe #3058

Open
damienwebdev opened this issue Sep 11, 2024 · 2 comments · May be fixed by #3368, #3369, #3370 or #3371
Open

[OTHER] Fixup warnings from jest/max-nested-describe #3058

damienwebdev opened this issue Sep 11, 2024 · 2 comments · May be fixed by #3368, #3369, #3370 or #3371
Assignees
@gracetxgao
Labels
good first issue This issue is a good place to start for first time contributors

Comments

@damienwebdev
Copy link
Member

damienwebdev commented Sep 11, 2024 •
edited
Loading

❓ Other

Re: #3056

We should fix any describe depths at 4 and 5 and, afterward, we can adjust jest/max-nested-describe to error at 4.
@damienwebdev damienwebdev added the good first issue This issue is a good place to start for first time contributors label Sep 11, 2024
@damienwebdev
Copy link
Member Author

@gracetxgao can you open the PR for the branch you worked on. Additionally, can you add to the issue the tests that have warnings (but would cause an error eventually)?

@gracetxgao
Copy link
Contributor

Files with warnings:

  • libs/auth/driver/magento/src/reset-password.service.spec.ts
  • libs/auth/state/src/effects/login.effects.spec.ts
  • libs/auth/state/src/effects/register.effects.spec.ts
  • libs/auth/state/src/effects/reset-password.effects.spec.ts
  • libs/cart/driver/magento/src/cart-address.service.spec.ts
  • libs/cart-customer/state/src/effects/auth.effects.spec.ts
  • libs/order/driver/magento/2-4-0/src/order.service.spec.ts
  • libs/order/driver/magento/2-4-1/src/order.service.spec.ts

This was referenced Dec 20, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gracetxgao gracetxgao

Labels
good first issue This issue is a good place to start for first time contributors
Projects
None yet
Milestone
No milestone
2 participants
@damienwebdev @gracetxgao