Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): create sticky tracker directive #2833

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Can't change styles depending on if a container is sticky or not.

Fixes: #2825

What is the new behavior?

Directive to calculate when a container is sticky to the page so that the .daff-sticky class can be added or removed, to assist with styling.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Directive doesn't work as intended at the moment. The class isn't being added/removed at the right time.

The example in home-view needs to be removed before merging.

@xelaint xelaint added the package: design @daffodil/design label Jun 7, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jun 7, 2024
@xelaint xelaint added the status: wip This PR is WIP. It should be marked as a draft. label Jul 1, 2024
@xelaint xelaint marked this pull request as ready for review July 10, 2024 13:19
@xelaint xelaint requested review from a team as code owners July 10, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Directive to track when a sticky element gets pinned
2 participants