Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed json runtime dependency breaks Ruby 1.9. compatibility #47

Open
petetnt opened this issue Aug 9, 2016 · 1 comment
Open

Relaxed json runtime dependency breaks Ruby 1.9. compatibility #47

petetnt opened this issue Aug 9, 2016 · 1 comment

Comments

@petetnt
Copy link

petetnt commented Aug 9, 2016

The README.md states that

Tested with Ruby 1.9, 2.0, 2.1, 2.2 and 2.3.

However, installing gelf on 1.9. leads to

gem install gelf
ERROR:  Error installing gelf:
    json requires Ruby version ~> 2.0.

The runtime_dependency is added as

s.add_runtime_dependency(%q<json>, [">= 0"])

So I assume that json had a breaking change somewhere which then breaks gelf-rb.

@milgner
Copy link
Contributor

milgner commented Aug 21, 2016

That is strange, the tests on Travis CI were all running successfully. Nonetheless, I have just published a new version to the master branch, could you give it a try? It should use json 1.8.3, which still supports older Rubies. Let me know if it does not work and I will add an explicit version restriction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants