Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The change in #53 broke fluentd config parsing #63

Open
griff opened this issue Oct 9, 2017 · 0 comments · May be fixed by #64
Open

The change in #53 broke fluentd config parsing #63

griff opened this issue Oct 9, 2017 · 0 comments · May be fixed by #64

Comments

@griff
Copy link

griff commented Oct 9, 2017

The fix in #53 breaks the fluentd config parser so that array and object literals can't be parsed.

Fluentd loads both yajl and json gem and uses the json gem to parse array and object literals in the fluentd.config and so when you monkey patch the json gem to use yajl it breaks the parser.
griff added a commit to griff/gelf-rb that referenced this issue Oct 9, 2017
@griff
Parse using Yajl.dump when available
9a4390a 
Fixes: graylog-labs#63
@griff griff linked a pull request Oct 9, 2017 that will close this issue
Open
This was referenced Oct 26, 2018
Closed
Closed
repeatedly added a commit to fluent/fluentd-kubernetes-daemonset that referenced this issue Oct 26, 2018
@repeatedly
Fix gelf-rb version to avoid fluentd breakage
39d3c54 
graylog-labs/gelf-rb#63

Signed-off-by: Masahiro Nakagawa <[email protected]>
@repeatedly repeatedly mentioned this issue Oct 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add json_dump method and use that for converting to json griff/gelf-rb
1 participant
@griff