Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json_dump method and use that for converting to json #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add json_dump method and use that for converting to json #64

wants to merge 1 commit into from

Conversation

griff
Copy link

@griff griff commented Oct 9, 2017

This adds a json_dump method that uses Yajl.dump when available and JSON.dump otherwise.

This fixes #63

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tessie
Copy link
Collaborator

tessie commented Oct 10, 2017

@griff json_dump is defined in two places. Could you please fix that.and please sign the contributor agreement

@milgner milgner mentioned this pull request Mar 18, 2018
Closed
@repeatedly repeatedly mentioned this pull request Nov 27, 2019
Closed
@scrwr scrwr mentioned this pull request Nov 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The change in #53 broke fluentd config parsing
3 participants
@griff @CLAassistant @tessie