Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.5.0: updated SSLContext interface #76

Open
milgner opened this issue Sep 13, 2018 · 3 comments
Open

Ruby 2.5.0: updated SSLContext interface #76

milgner opened this issue Sep 13, 2018 · 3 comments
Assignees
Labels

Comments

@milgner
Copy link
Contributor

milgner commented Sep 13, 2018

Assigning ctx.ciphers does not work anymore like it used to. We'll need to set min_version and max_version instead.

@milgner milgner added the bug label Sep 13, 2018
@milgner milgner self-assigned this Sep 13, 2018
@Simonot
Copy link

Simonot commented Oct 19, 2018

Hello,

Any update on that ?

Or should we use gelf 3.0.0 for ruby >= 2.5.0 ?

@chriscoester
Copy link

Not sure if this is a separate issue, but I'm getting:
SSL_CTX_set_cipher_list: invalid command
when trying to use tls. It seems like the cipher string

ctx.ciphers = "TLSv1_2:TLSv1_1:TLSv1:!aNULL:!eNULL:!LOW:!3DES:!MD5:!EXP:!PSK:!DSS:!RC4:!SEED:!ECDSA:!ADH:!IDEA:!3DES"

should be:

"TLSv1.2:TLSv1.1:TLSv1:!aNULL:!eNULL:!LOW:!3DES:!MD5:!EXP:!PSK:!DSS:!RC4:!SEED:!ECDSA:!ADH:!IDEA:!3DES"

Patching this solves the issue for me and is also in line with how the OpenSSL cli-tool behaves.

@matti
Copy link

matti commented Nov 21, 2019

^-- yep, this is required patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants