Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcposbal2csv.py doesn't extract segwit #15

Open
Jolly-Pirate opened this issue Mar 1, 2021 · 3 comments · May be fixed by #34
Open

btcposbal2csv.py doesn't extract segwit #15

Jolly-Pirate opened this issue Mar 1, 2021 · 3 comments · May be fixed by #34

Comments

@Jolly-Pirate
Copy link

btcposbal2csv.py doesn't extract segwit addresses, for example:

Public Address bc1 P2WPKH: bc1qetrqrygl7t0fn6hrdmuug3rrp8vjmum8fd8rsk
Public Address bc1 P2WSH: bc1q26swzzjmqgwvcjxplktpyj9xpkzpv8kgs7t545ku6s7v6fl0xt3slnx8k9
@graymauser
Copy link
Owner

graymauser commented Mar 3, 2021 •
edited
Loading

Yes, currently it does not support segwit address extraction. I'm not planning to add support at the moment. I would accept PR with the support.

There is open PR in bitcoin-core for txout dump (bitcoin/bitcoin#18689), if this is merged, it would be ideal solution and made this library obsolete.

@who-biz
Copy link

who-biz commented Aug 1, 2022 •
edited
Loading

Hi, I've added support for bech32 addresses in a repository located here: https://github.com/who-biz/chipsposbal2csv.

It has been modified to generate addresses with a different network byte, but the changes are easily portable if @Jolly-Pirate is still looking for a solution.

That repo is now compatible with P2WPKH & P2WSH txs

@who-biz who-biz linked a pull request Aug 2, 2022 that will close this issue
Open
@who-biz
Copy link

who-biz commented Aug 2, 2022

PR'ed changes for BTC network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatbility for bech32 (segwit) vouts who-biz/chipsposbal2csv
3 participants
@Jolly-Pirate @graymauser @who-biz