fix(idle,timeout): countdown idle and timeout based on time

[mychalhackman]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/HackedByChinese/ng2-idle/blob/master/CONTRIBUTING.md#pr
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Timeout and idle do not compensate for time-shifts (e.g.; clock change, device standby).

#110
#112

What is the new behavior?
Idle and timeout are checked every second (instead of once after idle expiry) and compare the system time against the timeout time.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

[coveralls]

Coverage remained the same at 100.0% when pulling db87c4c on qhrtech:fix-timeout-idle-time-shift into db0148b on HackedByChinese:master.

[kvetis]

This fix is very useful and we've used a "fork" with the almost exact code for years. It would be very helpful to merge this, since we could then upgrade to newer versions. It would also fix #157.

[chinthu]

It would be very helpful if you merge this fix.

[mcrtricolor]

I would also need this fix, thanks.

[gshirley-boku]

I need this fix too, can we have this fix merged anytime soon? 🙇‍♀️

[StefaniToto]

Need this fix as well.

[kemmis]

Please merge. We need this fix too.

[ZoSo1974]

I need it too! Please merge ASAP! :)

[Eldorados]

What is the issue with this PR? 4 years waiting for a much needed fix

Who is able to give the final review and merge?

[Eldorados]

Tested on my side and working well

[reunefe]

@moribvndvs would it be possible to get this one merged? Or does anybody else has write access to could approve this?

[grbsk]

The original model (from AngularJS days) avoided what is here (essentially polling) because of digest performance issues. I had proposed an alternate solution, which was to use the provided WindowInterruptSource along with the default or whatever interrupt sources you're using, which fires an interrupt (thus causing expiry checking) when the window is focused (you could also do focus for window or try visiblitychange). I did not add these to the default sources because it was a bit quirky and was new functionality anyways, and I would rather have let people decide if they needed it until it was rock solid.

Trying the PR myself, this core change seems to work fine without either of those work arounds, but I don't have something to test it exhaustively with. But if others have been trying it and it works, let's try it.

I think the knock on effect of this is the expiry system probably needs to be re-examined, but is currently necessary to synchronize between tabs of the same app. However, we could potentially replace that with a reworked storage event source, use BroadcastChannel, or window.postMessage.

[grbsk]

Thanks @mychalhackman and all who tested/reviewed it. Sorry it took a lifetime to merge.

[grbsk]

Do we need a minor release for the current target of Angular 15 (and do a separate release with it for 16), or just jump straight to 16?

[kemmis]

15 would be nice.

…

On Wed, Oct 25, 2023 at 12:42 PM Mike Grabski ***@***.***> wrote: Do we need a minor release for the current target of Angular 15 (and do a separate release with it for 16), or just jump straight to 16? — Reply to this email directly, view it on GitHub <#131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE6C6KDCBQXQAGZP6KOCV3YBE6Q7AVCNFSM4IVLFNM2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZXHE3DMNRTGUYA> . You are receiving this because you commented.Message ID: ***@***.***>

[Eldorados]

I am stuck on 15 for a while longer, so a minor release would be much appreciated on my end!

[reunefe]

I would do separate releases, 1 for the current target of Angular 15 and a separate one for Angular 16.
Mainly because Angular 16 has some breaking changes that could impact some things:

• Node upgrade
• Typescript upgrade
• etc

Not sure what the impact would be by using it in, for example my case, angular 14. The current target with angular 15 works fine in an application of Angular 14, but maybe that's just me. Unfortunately I'm still stuck to that version for now

[grbsk]

Since it's a fix only, 13.0.1 is the release with this change. It's out on NPM now.