Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove bot check on permissions checker action #10895

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

nicgrayson
Copy link
Contributor

We don't need to check if a user is a bot when trying to exit. We just want to fail this job if the user doesn't have permissions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We don't need to check if a user is a bot when trying to exit. We just want to fail this job if the user doesn't have permissions
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit defe204
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67993ba2b7e7c5000862d560

@nicgrayson nicgrayson requested a review from billdirks January 28, 2025 20:19
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (680b184) to head (defe204).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10895      +/-   ##
===========================================
+ Coverage    80.15%   80.76%   +0.60%     
===========================================
  Files          465      465              
  Lines        40624    40624              
===========================================
+ Hits         32562    32809     +247     
+ Misses        8062     7815     -247     
Flag Coverage Δ
3.10 70.07% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.50% <ø> (ø)
3.10 aws_deps 46.40% <ø> (ø)
3.10 big 54.89% <ø> (ø)
3.10 bigquery 48.65% <ø> (ø)
3.10 clickhouse 43.29% <ø> (ø)
3.10 databricks 50.43% <ø> (-0.01%) ⬇️
3.10 filesystem 62.88% <ø> (ø)
3.10 mssql 51.43% <ø> (ø)
3.10 mysql 51.81% <ø> (ø)
3.10 postgresql 54.45% <ø> (ø)
3.10 snowflake 51.21% <ø> (ø)
3.10 spark 57.78% <ø> (ø)
3.10 spark_connect 46.67% <ø> (ø)
3.10 trino 52.36% <ø> (?)
3.11 70.07% <ø> (ø)
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.50% <ø> (ø)
3.11 aws_deps 46.40% <ø> (ø)
3.11 big 54.89% <ø> (ø)
3.11 bigquery 48.65% <ø> (ø)
3.11 clickhouse 43.29% <ø> (ø)
3.11 databricks 50.43% <ø> (ø)
3.11 filesystem 62.88% <ø> (ø)
3.11 mssql 51.43% <ø> (ø)
3.11 mysql 51.81% <ø> (ø)
3.11 postgresql 54.45% <ø> (ø)
3.11 snowflake 51.21% <ø> (ø)
3.11 spark 57.78% <ø> (ø)
3.11 spark_connect 46.67% <ø> (ø)
3.11 trino 52.36% <ø> (ø)
3.12 70.05% <ø> (-0.02%) ⬇️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.50% <ø> (ø)
3.12 aws_deps 46.40% <ø> (ø)
3.12 big 54.89% <ø> (ø)
3.12 bigquery 48.65% <ø> (ø)
3.12 databricks 50.43% <ø> (+<0.01%) ⬆️
3.12 filesystem 62.88% <ø> (ø)
3.12 mssql 51.44% <ø> (ø)
3.12 mysql 51.81% <ø> (ø)
3.12 postgresql 54.45% <ø> (ø)
3.12 snowflake 51.21% <ø> (ø)
3.12 spark 57.78% <ø> (ø)
3.12 spark_connect 46.67% <ø> (ø)
3.12 trino 52.37% <ø> (ø)
3.9 70.10% <ø> (+<0.01%) ⬆️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.50% <ø> (ø)
3.9 aws_deps 46.42% <ø> (ø)
3.9 big 54.90% <ø> (ø)
3.9 bigquery 48.64% <ø> (ø)
3.9 clickhouse 43.31% <ø> (ø)
3.9 databricks 50.43% <ø> (+<0.01%) ⬆️
3.9 filesystem 62.89% <ø> (ø)
3.9 mssql 51.42% <ø> (ø)
3.9 mysql 51.79% <ø> (ø)
3.9 postgresql 54.44% <ø> (ø)
3.9 snowflake 51.21% <ø> (ø)
3.9 spark 57.75% <ø> (ø)
3.9 spark_connect 46.68% <ø> (ø)
3.9 trino 52.35% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 53.98% <ø> (?)
docs-creds-needed 52.86% <ø> (?)
docs-spark 52.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicgrayson nicgrayson enabled auto-merge January 28, 2025 21:25
@nicgrayson nicgrayson added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2025
@nicgrayson nicgrayson added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 28, 2025
@billdirks billdirks added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2025
@billdirks billdirks added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2025
@billdirks billdirks added this pull request to the merge queue Jan 29, 2025
Merged via the queue into develop with commit fd63b63 Jan 29, 2025
96 checks passed
@billdirks billdirks deleted the m/remove-bot-check-on-fail branch January 29, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants