Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove Domain mixin from Metrics API #10966

Merged
merged 100 commits into from
Feb 27, 2025

Conversation

NathanFarmer
Copy link
Contributor

Remove the Domain mixin from the metrics API in favor of Metric subclasses

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

NathanFarmer and others added 30 commits February 18, 2025 21:33
…ctations/great_expectations into f/gx-40/batch-compute-metrics
@NathanFarmer NathanFarmer changed the base branch from develop to f/gx-46/query-metric February 25, 2025 05:31
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 3011339
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67bf9a5316929a0008a9132d

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (06cebf0) to head (3011339).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10966      +/-   ##
===========================================
- Coverage    80.85%   80.84%   -0.01%     
===========================================
  Files          474      479       +5     
  Lines        40857    40838      -19     
===========================================
- Hits         33035    33017      -18     
+ Misses        7822     7821       -1     
Flag Coverage Δ
3.10 70.23% <100.00%> (-0.03%) ⬇️
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.69% <98.21%> (?)
3.10 aws_deps 46.53% <85.71%> (?)
3.10 big 54.97% <85.71%> (?)
3.10 bigquery 48.93% <98.21%> (?)
3.10 clickhouse 43.44% <85.71%> (?)
3.10 databricks 50.68% <98.21%> (?)
3.10 filesystem 63.02% <96.42%> (?)
3.10 mssql 51.68% <96.42%> (?)
3.10 mysql 51.90% <85.71%> (?)
3.10 postgresql 54.68% <98.21%> (?)
3.10 snowflake 51.44% <98.21%> (?)
3.10 spark 57.97% <98.21%> (?)
3.10 spark_connect 46.85% <85.71%> (?)
3.10 trino 52.45% <85.71%> (?)
3.11 70.24% <100.00%> (-0.02%) ⬇️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.69% <98.21%> (?)
3.11 aws_deps 46.53% <85.71%> (?)
3.11 big 54.97% <85.71%> (?)
3.11 bigquery 48.93% <98.21%> (?)
3.11 clickhouse 43.44% <85.71%> (?)
3.11 databricks 50.67% <98.21%> (?)
3.11 filesystem 63.02% <96.42%> (?)
3.11 mssql 51.68% <96.42%> (?)
3.11 mysql 51.90% <85.71%> (?)
3.11 postgresql 54.68% <98.21%> (?)
3.11 snowflake 51.44% <98.21%> (?)
3.11 spark 57.97% <98.21%> (?)
3.11 spark_connect 46.85% <85.71%> (?)
3.11 trino 52.45% <85.71%> (?)
3.12 70.24% <100.00%> (+<0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.69% <98.21%> (-0.01%) ⬇️
3.12 aws_deps 46.53% <85.71%> (+<0.01%) ⬆️
3.12 big 54.96% <85.71%> (+<0.01%) ⬆️
3.12 bigquery 48.93% <98.21%> (-0.02%) ⬇️
3.12 databricks 50.68% <98.21%> (-0.02%) ⬇️
3.12 filesystem 63.02% <96.42%> (-0.01%) ⬇️
3.12 mssql 51.68% <96.42%> (-0.02%) ⬇️
3.12 mysql 51.91% <85.71%> (+<0.01%) ⬆️
3.12 postgresql 54.68% <98.21%> (-0.01%) ⬇️
3.12 snowflake 51.44% <98.21%> (-0.02%) ⬇️
3.12 spark 57.97% <98.21%> (-0.01%) ⬇️
3.12 spark_connect 46.85% <85.71%> (+<0.01%) ⬆️
3.12 trino 52.45% <85.71%> (+<0.01%) ⬆️
3.9 70.25% <100.00%> (-0.03%) ⬇️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.69% <98.21%> (-0.01%) ⬇️
3.9 aws_deps 46.55% <85.71%> (+<0.01%) ⬆️
3.9 big 54.98% <85.71%> (+<0.01%) ⬆️
3.9 bigquery 48.93% <98.21%> (-0.02%) ⬇️
3.9 clickhouse 43.45% <85.71%> (+<0.01%) ⬆️
3.9 databricks 50.68% <98.21%> (-0.01%) ⬇️
3.9 filesystem 63.02% <96.42%> (-0.01%) ⬇️
3.9 mssql 51.66% <96.42%> (-0.02%) ⬇️
3.9 mysql 51.89% <85.71%> (+<0.01%) ⬆️
3.9 postgresql 54.67% <98.21%> (-0.01%) ⬇️
3.9 snowflake 51.44% <98.21%> (-0.02%) ⬇️
3.9 spark 57.93% <98.21%> (-0.01%) ⬇️
3.9 spark_connect 46.86% <85.71%> (+<0.01%) ⬆️
3.9 trino 52.43% <85.71%> (+<0.01%) ⬆️
cloud 0.00% <0.00%> (ø)
docs-basic 54.04% <85.71%> (+0.02%) ⬆️
docs-creds-needed 52.92% <85.71%> (+0.02%) ⬆️
docs-spark 52.47% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NathanFarmer NathanFarmer marked this pull request as ready for review February 25, 2025 07:02
@NathanFarmer NathanFarmer changed the base branch from f/gx-46/query-metric to develop February 25, 2025 16:27
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems simpler.

raise MissingAttributeError(name, "name")
MetaMetric._registry[metric_name] = register_cls
metric_name = attrs.get("name")
# Some subclasses of metric may not have a name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we'd define a metric and then not register it. What's the use case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New subclasses like BatchMetric, ColumnMetric, etc

@NathanFarmer NathanFarmer added this pull request to the merge queue Feb 27, 2025
Merged via the queue into develop with commit f9dba6f Feb 27, 2025
100 checks passed
@NathanFarmer NathanFarmer deleted the m/remove-domain-mixin branch February 27, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants