-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Remove Domain
mixin from Metrics API
#10966
Conversation
…e than 1 of the same metric
…ctations/great_expectations into f/gx-40/batch-compute-metrics
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10966 +/- ##
===========================================
- Coverage 80.85% 80.84% -0.01%
===========================================
Files 474 479 +5
Lines 40857 40838 -19
===========================================
- Hits 33035 33017 -18
+ Misses 7822 7821 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
57358c6
to
2f34a61
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This seems simpler.
raise MissingAttributeError(name, "name") | ||
MetaMetric._registry[metric_name] = register_cls | ||
metric_name = attrs.get("name") | ||
# Some subclasses of metric may not have a name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why we'd define a metric and then not register it. What's the use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New subclasses like BatchMetric, ColumnMetric, etc
Remove the
Domain
mixin from the metrics API in favor ofMetric
subclassesinvoke lint
(usesruff format
+ruff check
)