Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Conform to OS/browser native dark/light mode setting #887

Open
quenz opened this issue Mar 15, 2019 · 6 comments
Open

Feature request: Conform to OS/browser native dark/light mode setting #887

quenz opened this issue Mar 15, 2019 · 6 comments

Comments

@quenz
Copy link

quenz commented Mar 15, 2019

  • The Great Suspender v7.0.109
  • Google Chrome 73.0.3683.75 (Official Build) (64-bit)
  • macOS Mojave 10.14.3

Chrome's UI now conforms to the light/dark appearance setting in macOS.

From Google Developers:

Dark mode for Chrome's UI is now supported on Mac, and Windows support is on the way. In addition, there's work on a CSS media query: prefers-color-scheme, that can be used to detect if the user has requested the system use a light or dark color theme. The tracking bug for this is Add support for CSS prefers-color-scheme media feature For Chrome, and Firefox.

I'm hoping this could be extended, so that the suspended tab page automatically changes depending on the native setting.

I'm not a developer, but Perhaps the CSS thing they mention could be used on the suspended tab page, since it is an HTML page?

@liamjohnston
Copy link
Contributor

@quenz yes, I've been thinking we should add this. Keen to keep new non-critical features out of the upcoming next release, but maybe I'll make a PR next time I get the chance 😊

I'm thinking it should be a third option in the theme dropdown, like "system setting" (or similar). We'd make it the default for those who currently have the default "light" set.

@deanoemcke Sound good?

@deanoemcke
Copy link
Collaborator

Lets put it in this release! :P

@liamjohnston
Copy link
Contributor

@quenz
PR is here: #888

We're putting this on ice until Chrome ~v75 is out.

Chrome v73 only adds support for Chrome itself to use on its tab bar etc, and doesn't provide access to the CSS media query (or JS matchMedia).

@piotr-chylarecki
Copy link

Guys,
do you have plans to bring this? (When?)

Switching the mode manually twice every day is nuts.

@yorhodes
Copy link

I would be happy to implement this for one of the forks
cc @aciidic

@aciidic
Copy link

aciidic commented Sep 14, 2021

I would be happy to implement this for one of the forks
cc @aciidic

Sorry late reply, but I do check in on the fork occasionally and happy to accept pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants