Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate HTML plugin (linter or nor ?) #1

Closed
dedece35 opened this issue Apr 10, 2023 · 5 comments · Fixed by #3
Closed

Initiate HTML plugin (linter or nor ?) #1

dedece35 opened this issue Apr 10, 2023 · 5 comments · Fixed by #3
Assignees
Labels
🚀 enhancement New feature or request

Comments

@dedece35
Copy link
Member

dedece35 commented Apr 10, 2023

during 2023 hackathon, several ideas around HTML linter appears.
Maybe a new language has to be included to plugin (linter or not) to integrate some existing rules.
examples :

@utarwyn ? do you have a point of view ?

@utarwyn
Copy link
Member

utarwyn commented Apr 11, 2023

Hello, yes we have to set up a linter to analyze the HTML code. It will be useful for many rules! But I think that we have to separate it from JavaScript/TypeScript plugin. We are discussing this in green-code-initiative/creedengo-javascript#4

@dedece35
Copy link
Member Author

@utarwyn @MP-Aubay
I let you assign yourself this issue, please.

@MP-Aubay MP-Aubay self-assigned this Jun 26, 2023
@dedece35
Copy link
Member Author

dedece35 commented Sep 22, 2023

Hi @MP-Aubay, @utarwyn, (@glalloue )
as mentionned on green-code-initiative/creedengo-javascript#4
the ecoCode-html repository has been created 3 months ago.
inside, there is an "html-plugin" and "css-plugin" ... what do you think about it ?
I think, we can keep ecoCode-html only for html-plugin and create a new one for css part ? "ecoCode-css" ?

Could we make a technical point about this discussion, please ?
When can we do this point, next week ?

TO DISCUSS INSIDE CORE-TEAM : ok or not ok with these ideas

@utarwyn
Copy link
Member

utarwyn commented Sep 22, 2023

Hello @dedece35,
as I said during a meeting this summer, I have started to work on the HTML/CSS plugin last weeks with the code base made by Mickael in his branch. I'm testing different configurations to know which one is the best (HTML-CSS together or not, usage of a linter or not).

Did you have time to work on it @MP-Aubay? If the subject still interests you, we can work together

So I propose to organize a dedicated technical meeting once my researches will be completed, to discuss the different solutions and with benefits and disadvantages. I keep you informed 👍

@MP-Aubay
Copy link

Hello @dedece35 @utarwyn ,

Sorry I was a bit out of EcoCode lately.

I had clone David's repository and start to include my code, for now removing the css part. I need to update myself with recent changes, like centralized rules and what's new in JS plugin (@utarwyn do you manage to include rules from linter in Sonarqube ?).

Agreed with the dedicated meeting, @utarwyn if you need my help for the researches, feel free to assign me some task to look for.

@utarwyn utarwyn transferred this issue from green-code-initiative/creedengo-rules-specifications Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants