From 70794dbeb040771d2c7482a727866f8c9ac86a93 Mon Sep 17 00:00:00 2001 From: Matt Mundell Date: Sat, 29 Jun 2024 08:16:15 +0200 Subject: [PATCH] Fix: add missing returns in modify_config_run --- src/gmp_configs.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/gmp_configs.c b/src/gmp_configs.c index f7d550dd4..b5935f14a 100644 --- a/src/gmp_configs.c +++ b/src/gmp_configs.c @@ -1026,12 +1026,18 @@ modify_config_run (gmp_parser_t *gmp_parser, GError **error) config_id = attr_or_null (entity, "config_id"); if (config_id == NULL) - SEND_TO_CLIENT_OR_FAIL - (XML_ERROR_SYNTAX ("modify_config", - "A config_id attribute is required")); + { + SEND_TO_CLIENT_OR_FAIL + (XML_ERROR_SYNTAX ("modify_config", + "A config_id attribute is required")); + return; + } else if (config_predefined_uuid (config_id)) - SEND_TO_CLIENT_OR_FAIL (XML_ERROR_SYNTAX ("modify_config", - "Permission denied")); + { + SEND_TO_CLIENT_OR_FAIL (XML_ERROR_SYNTAX ("modify_config", + "Permission denied")); + return; + } // Find the config switch (manage_modify_config_start (config_id, &config)) @@ -1053,6 +1059,7 @@ modify_config_run (gmp_parser_t *gmp_parser, GError **error) SEND_TO_CLIENT_OR_FAIL (XML_INTERNAL_ERROR ("modify_config")); log_event_fail ("config", "Scan Config", config_id, "modified"); + return; } // Handle basic attributes and elements