Add tests for java version parsing #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
=======================================
Coverage 89.84% 89.85%
=======================================
Files 88 88
Lines 5911 5913 +2
Branches 838 838
=======================================
+ Hits 5311 5313 +2
Misses 421 421
Partials 179 179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjoernricks
approved these changes
Oct 9, 2023
bjoernricks
force-pushed
the
fix/java_version_detection
branch
from
4e66b7c
to
c1cd5ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Java version detection was not recognizing all suffixes of a version string