Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual override of date doesn't work in citations #245

Closed
1 task done
michaelpginn opened this issue Mar 13, 2024 · 2 comments · Fixed by #247
Closed
1 task done

Manual override of date doesn't work in citations #245

michaelpginn opened this issue Mar 13, 2024 · 2 comments · Fixed by #247
Labels
bug Something isn't working

Comments

@michaelpginn
Copy link

Checks

Link to your website repo

https://github.com/lecs-lab/lecs-lab.github.io

Version of Lab Website Template you are using

1.2.0

Description

I am trying to manually override the date field in my sources, as in

- id: doi:10.18653/v1/2023.genbench-1.7
  date: 2023-12-01

However, this does not seem to work, as the citations.yaml file contains

- id: doi:10.18653/v1/2023.genbench-1.7
  title: Robust Generalization Strategies for Morpheme Glossing in an Endangered Language
    Documentation Context
  authors:
  - Michael Ginn
  - Alexis Palmer
  publisher: Proceedings of the 1st GenBench Workshop on (Benchmarking) Generalisation
    in NLP
  date: ''
  link: https://doi.org/gtmsc3
  plugin: sources.py
  file: sources.yaml

Is there something else I have to do to get this override to work? The dates that are automatically pulled are not correct.

@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Mar 13, 2024

This is a bug. For now you can wrap your data in double quotes and that should fix it. Also see this fix on branch v1.2.1:

7936075

Since hopefully most people won't run into this niche bug case, I'm going to wait a little bit before releasing 1.2.1 to see if there are any regressions from 1.2.0 or other bugs I'd want to include in the new version.

@vincerubinetti vincerubinetti added the bug Something isn't working label Mar 13, 2024
@michaelpginn
Copy link
Author

That worked, thanks!

@vincerubinetti vincerubinetti linked a pull request Mar 23, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants