fix handling of greenmail.sieve.ignore.detail prop
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-lr
changed the title
greenmail.sieve.ignore.detail propgreenmail.sieve.ignore.detail prop
shlomi-lr
force-pushed
the
fix-handling-of-greenmail-sieve-ignore-detail-prop
branch
from
11055a4 to
43535a8
Compare
marcelmay
reviewed
Nov 26, 2024
| @@ -80,7 +80,7 @@ public GreenMailConfiguration build(Properties properties) { | |||
| } | |||
|
|
|||
| String sieveIgnoreDetail = properties.getProperty(GREENMAIL_SIEVE_IGNORE_DETAIL, "false"); | |||
| if (null != sieveIgnoreDetail) { | |||
| if (Boolean.TRUE.toString().equalsIgnoreCase(sieveIgnoreDetail)) { | |||
There was a problem hiding this comment.
Might be easier to read:
if (Boolean.parseBoolean(sieveIgnoreDetail)) ...
There was a problem hiding this comment.
it is! I just wanted the review to show the details of the actual string comparison taking place but parseBoolean is really:
public static boolean parseBoolean(String s) {
return "true".equalsIgnoreCase(s);
}
thank you! :)
marcelmay
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
I've only a rather cosmetical comment.
Feel free to update PR regarding the comment, otherwise I'll merge the PR ~ tomorrow.
Thx alot, @shlomi-lr !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.