Issue #62 - mostly fixed #84
Conversation
…on implementation.
…ctions. The RootFolder's factory will be passed on to its children.
- Added configuration option to use this new Managers class. - Added reset() method to Managers in order to prevent reinstantiation of Managers object itself which would require additional reflection now..
- Added configuration option to use this new Managers class. - Added reset() method to Managers in order to prevent reinstantiation of Managers object itself which would require additional reflection now..
- Added configuration option to use this new Managers class. - Added reset() method to Managers in order to prevent reinstantiation of Managers object itself which would require additional reflection now..
|
Please forgive my ignorance, but I can't see why the tests failed now. They're all green on my machine, and I'm afraid I don't know how to rerun the build on CircleCI. Can someone help please? |
|
The CircleCI build is failing due to an issue with running tests repeatedly after another on Linux/Unix systems. See issue #69 for more details. |
|
Hmm, that's too bad. Thank you for the information. I'll follow the discussion there now and see if I can help. |
|
Hi Raimund, thnks for your commit. Currently our CI is a bit broken... Raimund Klein [email protected] schrieb am Do., 2. Juli 2015 um
|
|
The Factory itself offers a configuration option now. If requested, we can expose this via the main configuration class, but I see little value in that. Other than that, this should resolve the issue. |
|
@Chessray The build issues have been fixed. It looks like there are some conflicts though. Can you rebase your branch and update the PR? |
|
@buildscientist I fetched the latest upstream and merged, but something must have gone wrong - builds on my branch are still failing. What did I miss? |
|
@Chessray Can you fetch the latest upstream and re-run the build? We've fixed our CI/build related issues. |
|
Merged upstream. Let's hope it'll work now. |
|
@Chessray Looks like it worked but @marcelmay and I are still working on code reviewing your change. Please standby. |
Hi,
This pull request should resolve issue #62 - I just don't like that there is no way to configure the size given in com.icegreen.greenmail.store.StoredMessageCollectionFactory#createCollection. I'm open for suggestions by the guys who know this library better than I do.