From 428e70cd8aa57e49662d64d801683928dda1baa2 Mon Sep 17 00:00:00 2001 From: Patrick Figel Date: Wed, 25 Sep 2024 17:09:03 +0200 Subject: [PATCH] GP-44570 Fix start_date being required This fixes an issue with start_date being defined as NOT NULL, which is not the case during async execution. --- CRM/Sqltasks/DAO/SqltasksExecution.php | 4 ++-- sql/auto_install.sql | 2 +- xml/schema/CRM/Sqltasks/SqltasksExecution.xml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CRM/Sqltasks/DAO/SqltasksExecution.php b/CRM/Sqltasks/DAO/SqltasksExecution.php index 22e9e34..50f8821 100644 --- a/CRM/Sqltasks/DAO/SqltasksExecution.php +++ b/CRM/Sqltasks/DAO/SqltasksExecution.php @@ -6,7 +6,7 @@ * * Generated from de.systopia.sqltasks/xml/schema/CRM/Sqltasks/SqltasksExecution.xml * DO NOT EDIT. Generated by CRM_Core_CodeGen - * (GenCodeChecksum:ee61d590625c7cb56c54bcbe5317b2ae) + * (GenCodeChecksum:fa4de32875d01a8b099e2d357fa8a670) */ use CRM_Sqltasks_ExtensionUtil as E; @@ -213,7 +213,7 @@ public static function &fields() { 'type' => CRM_Utils_Type::T_DATE + CRM_Utils_Type::T_TIME, 'title' => E::ts('Start Date'), 'description' => E::ts('Start date of execution'), - 'required' => TRUE, + 'required' => FALSE, 'usage' => [ 'import' => FALSE, 'export' => FALSE, diff --git a/sql/auto_install.sql b/sql/auto_install.sql index c6ed6d2..6a07ae9 100644 --- a/sql/auto_install.sql +++ b/sql/auto_install.sql @@ -83,7 +83,7 @@ ENGINE=InnoDB; CREATE TABLE `civicrm_sqltasks_execution` ( `id` int unsigned NOT NULL AUTO_INCREMENT COMMENT 'Unique SqltasksExecution ID', `sqltask_id` int unsigned COMMENT 'FK to SQL Task', - `start_date` datetime NOT NULL COMMENT 'Start date of execution', + `start_date` datetime NULL COMMENT 'Start date of execution', `end_date` datetime NULL COMMENT 'End date of execution', `runtime` int unsigned NULL COMMENT 'Task runtime in milliseconds', `input` longtext NULL COMMENT 'Task input', diff --git a/xml/schema/CRM/Sqltasks/SqltasksExecution.xml b/xml/schema/CRM/Sqltasks/SqltasksExecution.xml index 2dbe866..4f34cb9 100644 --- a/xml/schema/CRM/Sqltasks/SqltasksExecution.xml +++ b/xml/schema/CRM/Sqltasks/SqltasksExecution.xml @@ -40,7 +40,7 @@ start_date Start Date datetime - true + false Start date of execution Select Date