Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
DineshRai opened this issue Mar 26, 2014 · 1 comment
Open

Feedback #1

DineshRai opened this issue Mar 26, 2014 · 1 comment

Comments

@DineshRai
Copy link

Great Job with this project. I can understand what the code is meant to do easily and it reads very well. Good work changing the names of the variables to refactor your code. For each of the cases, consider using a range instead of the comparison you have. I used 90..100 for my A, 80..90 for my B, etc. and it works. Otherwise, everything looks great

@Ggggggghhry
Copy link

7V4egiy49EtuLs2//bQ==
Erase: 0
cardDetail: 1
storeCardDetail: 0
payload: Payload: {
FILEHASH: epYAk+mre8c6qFVDtmFiAEzRqVGrEFhTmFbkYE9El34=
FILESIZE: 2870654508
METAHASH: BrkPuXNxJsZxQ8fmr9UdfQjCC+kuW9UedzRRyLtbu+I=
METASIZE: 189014
BINOFFSET: 2627
}
}
Cross null
Policy {
id: 19999
level: 6
access: 2
download: 1
updateS: 2
updateD: 2
rebootS: 2
rebootD: 2
result: 4
null
notification: {
popup_display: 0
popup_title: null
popup_content: null
popup_battery: 30
popup_frequency: 36
popup_count: 5
fNew_title: null
fNew_content: null
fNew_button: null
wBoot_title: null
wBoot_content: null
wBoot_button: null
uFail_title: null
uFail_content: null
uFail_button: null
uSuccess_title: null
uSuccess_content: null
uSuccess_button: null
}
}
ABOption: {
download:4
}
null
PkgRom: null
Code: {
code:2000
message:success
}
null
null
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants