Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing code for background data #58

Open
ghost opened this issue Oct 6, 2019 · 4 comments
Open

missing code for background data #58

ghost opened this issue Oct 6, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 6, 2019

Looking through tutorial here i notice that the first_nes codebase seems to lack code to copy the nametable etc to memory.

unless im mistaken?

link 1 https://taywee.github.io/NerdyNights/nerdynights/backgrounds.html

@gregkrsak
Copy link
Owner

You're correct-- I intentionally omitted it for the time being.

However, that's a good idea to include it. I don't have time to do it right now, but if you want to fork the repo and submit a really clean pull request for it, I'd be happy to add you as a co-author.

@ghost
Copy link
Author

ghost commented Oct 6, 2019

that's cool and understandable, i will try to provide a pr soon. thanks for quick response

@gregkrsak gregkrsak assigned gregkrsak and ghost and unassigned gregkrsak Oct 18, 2019
@ghost
Copy link
Author

ghost commented Oct 18, 2019

pr sent. hopefully i have presented it in a way that fits your style.

@gregkrsak
Copy link
Owner

This code is now in branch patch_01 for further development.

I had initially merged the pull request into staging, but felt it wasn't complete enough. I'm excited to work on this more (or have you work on it), but it needs a little cleaning up before hitting staging or master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant