Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PluginPosition.None to quickly hide a plugin #1456

Open
mbolli opened this issue Jun 21, 2024 · 0 comments · May be fixed by #1469
Open

Add PluginPosition.None to quickly hide a plugin #1456

mbolli opened this issue Jun 21, 2024 · 0 comments · May be fixed by #1469

Comments

@mbolli
Copy link

mbolli commented Jun 21, 2024

Is your feature request related to a problem? Please describe.

Showing a plugin conditionally is already possible with PluginManager.remove() and PluginManager.add().
However, it is even easier to set Plugin.position to a non-existing PluginPosition.
This works, but shows obviously a TypeScript warning TS2339: Property None does not exist on type typeof PluginPosition.

Describe the solution you'd like

To add PluginPosition.None to the Enum would not hurt anyone.

Describe alternatives you've considered

To ts-ignore my assignment line

Additional context

--

@mbolli mbolli linked a pull request Jul 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant